fix(ibc-core): copy substitute consensus state during client recovery #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 64.33% 64.41% +0.07%
==========================================
Files 229 230 +1
Lines 22083 22112 +29
==========================================
+ Hits 14208 14243 +35
+ Misses 7875 7869 -6 ☔ View full report in Codecov by Sentry. |
…om/cosmos/ibc-rs into sean/fix/client-recovery-consensus
rnbguy
reviewed
Apr 25, 2024
rnbguy
force-pushed
the
sean/fix/client-recovery-consensus
branch
from
b93b3c3 to
6f52da0
Compare
rnbguy
reviewed
Apr 26, 2024
rnbguy
changed the title
rnbguy
approved these changes
Apr 26, 2024
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…#1197) * Pass substitute consensus state into client recovery methods * Fix update_on_recovery call in ibc-clients/cw-context * refactor encode_vec to into_any * consume new_client_state later * update ibc_derive * update mock client state * cargo format * Change `use` statement formatting * add store_update_meta at MockClientState::initialise * consistent naming * Remove `into_any` trait methods * rm ConsensusState::into_any from ibc-derive * test consensus state recovery * link on doc strings --------- Co-authored-by: Ranadeep Biswas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1196
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.